Add support for Network Tier configuration by printchard · Pull Request #15083 · GoogleCloudPlatform/magic-modules

printchard · 2025-09-08T19:45:19Z

Release Note Template for Downstream PRs (will be copied)

container: added `network_tier_config` to `google_container_cluster` resource.

modular-magician · 2025-09-08T19:56:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 182 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 182 insertions(+), 1 deletion(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [ip_allocation_policy.network_tier_config ip_allocation_policy.network_tier_config.network_tier]

modular-magician · 2025-09-08T19:58:33Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccContainerCluster_network_tier_config

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-09-17T21:52:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 173 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 173 insertions(+), 1 deletion(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [ip_allocation_policy.network_tier_config ip_allocation_policy.network_tier_config.network_tier]

modular-magician · 2025-09-17T21:54:19Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccContainerCluster_network_tier_config

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-10-09T21:05:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 172 insertions(+))
google-beta provider: Diff ( 4 files changed, 172 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [ip_allocation_policy.network_tier_config ip_allocation_policy.network_tier_config.network_tier]

modular-magician · 2025-10-09T21:45:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 172 insertions(+))
google-beta provider: Diff ( 4 files changed, 172 insertions(+))

github-actions · 2025-10-20T17:17:55Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

printchard · 2025-10-20T17:26:35Z

Test failures analysis

Some of the VCR tests are failing after my changes, but all of them seem unrelated to the changes I am making in this PR. Please look at the following breakdown.

Recording mode

TestAccContainerNodePool_withNetworkConfig: This seems to be unrelated to the changes. No changes were made to the node pool.

Replaying mode

TestAccContainerCluster_withKubeletResourceManagerConfig: This looks unrelated to the changes as well, config diff with multiple fields.
TestAccContainerCluster_withMasterAuthorizedNetworksConfig: Timeout, unrelated to the changes.
TestAccContainerCluster_withNodePoolResize: Timeout, unrelated to the changes
TestAccContainerCluster_withTPUConfig: Invalid config, unrelated to the changes
TestAccContainerCluster_withTpu: Invalid config, unrelated to the changes
TestAccContainerNodePool_performanceMonitoringUnit: Timeout, unrelated to the changes
TestAccContainerNodePool_resize: Status fail, unrelated to changes
TestAccContainerNodePool_resourceManagerTags: Timeout, unrelated to the changes
TestAccContainerNodePool_secondaryBootDisks: Errored, unrelated to the changes
TestAccContainerNodePool_withKubeletConfig: Config diff, unrelated to the changes
TestAccContainerNodePool_withLinuxNodeConfig: Timeout, unrelated to the changes
TestAccContainerNodePool_withNodeConfigWithBootDiskConfig: Timeout, unrelated to the changes

modular-magician · 2025-10-21T21:12:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 172 insertions(+))
google-beta provider: Diff ( 4 files changed, 172 insertions(+))

printchard · 2025-10-22T02:51:30Z

Test failures analysis

I pushed changes to solve a documentation conflict, as such, all of these failures seem unrelated to the changes, as the code hasn't been touched. Additionally, there seems to be a quota issue as most failures seem related to the project hitting a count limit or being unable to reserve IP addresses.

printchard · 2025-10-23T20:00:47Z

Thanks for fixing the tests! Looks like the test I introduced broke, I will take a look into that.

modular-magician · 2025-10-23T21:01:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 168 insertions(+))
google-beta provider: Diff ( 4 files changed, 168 insertions(+))

modular-magician · 2025-10-23T21:31:38Z

Tests analytics

Total tests: 260
Passed tests: 230
Skipped tests: 11
Affected tests: 19

Click here to see the affected service packages

container

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_network_tier_config

TestAccContainerCluster_withAdvancedDatapath

TestAccContainerCluster_withAutoscalingProfile

TestAccContainerCluster_withNodePoolAutoscaling

TestAccContainerCluster_withNodePoolResize

TestAccContainerCluster_withNodePoolUpdateVersion

TestAccContainerCluster_withPodAutoscaling

TestAccContainerCluster_withSecurityPostureConfig

TestAccContainerCluster_withTPUConfig

TestAccContainerCluster_withTpu

TestAccContainerCluster_withWorkloadALTSConfig

TestAccContainerNodePool_basicWithClusterId

TestAccContainerNodePool_gvnic

TestAccContainerNodePool_resize

TestAccContainerNodePool_secondaryBootDisks

TestAccContainerNodePool_withEnablePrivateNodesToggle

TestAccContainerNodePool_withKubeletConfig

TestAccContainerNodePool_withLoggingVariantUpdates

TestAccContainerNodePool_withNetworkConfig

Get to know how VCR tests work

printchard · 2025-10-23T22:15:21Z

@melinath The fix is done! The failing tests seem unrelated to the changes, as they have been failing in multiple PRs for a while now. PTAL. Thanks!!

github-actions · 2025-10-27T09:44:58Z

@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

shuyama1 · 2025-10-27T17:17:00Z

Fixed more of the GKE issues. Triggering a new run to record cassettes for this PR. Sorry for the noise!

/gcbrun

modular-magician · 2025-10-27T17:32:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 168 insertions(+))
google-beta provider: Diff ( 4 files changed, 168 insertions(+))

modular-magician · 2025-10-27T17:58:03Z

Tests analytics

Total tests: 260
Passed tests: 243
Skipped tests: 11
Affected tests: 6

Click here to see the affected service packages

container

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_networkPerformanceConfig

TestAccContainerCluster_network_tier_config

TestAccContainerCluster_withAdditiveVPC

TestAccContainerCluster_withTPUConfig

TestAccContainerCluster_withTpu

TestAccContainerNodePool_secondaryBootDisks

Get to know how VCR tests work

modular-magician · 2025-10-27T18:36:16Z

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_network_tier_config [Debug log]
TestAccContainerCluster_withAdditiveVPC [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_networkPerformanceConfig [Error message] [Debug log]
TestAccContainerCluster_withTPUConfig [Error message] [Debug log]
TestAccContainerCluster_withTpu [Error message] [Debug log]
TestAccContainerNodePool_secondaryBootDisks [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

printchard · 2025-10-27T21:27:36Z

Hello maintainers. Thanks for the effort cleaning up the tests. It seems like the remaining failures are still unrelated. PTAL.

melinath

overall looks good; just a few small change suggestions.

melinath · 2025-10-27T22:56:43Z

mmv1/third_party/terraform/services/container/resource_container_cluster.go.tmpl

+										Optional:     true,
+										Default:	  "NETWORK_TIER_DEFAULT",


I'd recommend marking this as Required: true so that if the network_tier_config block is specified, users must provide a value for network_tier.

Generally we try to avoid allowing empty blocks (unless they have a special meaning separate from the block being omitted.)

Suggested change

Optional: true,

Default: "NETWORK_TIER_DEFAULT",

Required: true,

melinath · 2025-10-27T22:57:16Z

mmv1/third_party/terraform/services/container/resource_container_cluster.go.tmpl

+										Type:         schema.TypeString,
+										Optional:     true,
+										Default:	  "NETWORK_TIER_DEFAULT",
+										ValidateFunc: validation.StringInSlice([]string{"NETWORK_TIER_DEFAULT", "NETWORK_TIER_STANDARD", "NETWORK_TIER_PREMIUM"}, false),


If there's a chance that more values will be added in the future, you might want to leave off the validation func so that the field will be forwards-compatible.

mmv1/third_party/terraform/services/container/resource_container_cluster_test.go.tmpl

printchard

Thanks for the feedback. I have made the requested changes, PTAL.

printchard · 2025-10-28T22:44:33Z

mmv1/third_party/terraform/services/container/resource_container_cluster.go.tmpl

+										Optional:     true,
+										Default:	  "NETWORK_TIER_DEFAULT",


mmv1/third_party/terraform/services/container/resource_container_cluster_test.go.tmpl

printchard · 2025-10-28T22:46:37Z

mmv1/third_party/terraform/services/container/resource_container_cluster.go.tmpl

+										Type:         schema.TypeString,
+										Optional:     true,
+										Default:	  "NETWORK_TIER_DEFAULT",
+										ValidateFunc: validation.StringInSlice([]string{"NETWORK_TIER_DEFAULT", "NETWORK_TIER_STANDARD", "NETWORK_TIER_PREMIUM"}, false),


modular-magician · 2025-10-28T22:54:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 170 insertions(+))
google-beta provider: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2025-10-28T23:22:45Z

Tests analytics

Total tests: 260
Passed tests: 245
Skipped tests: 11
Affected tests: 4

Click here to see the affected service packages

container

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_networkPerformanceConfig

TestAccContainerCluster_withTPUConfig

TestAccContainerCluster_withTpu

TestAccContainerNodePool_secondaryBootDisks

Get to know how VCR tests work

modular-magician · 2025-10-29T00:00:06Z

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_networkPerformanceConfig [Error message] [Debug log]
TestAccContainerCluster_withTPUConfig [Error message] [Debug log]
TestAccContainerCluster_withTpu [Error message] [Debug log]
TestAccContainerNodePool_secondaryBootDisks [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

melinath · 2025-10-29T16:08:28Z

Failing tests look unrelated.

modular-magician added the service/container label Sep 8, 2025

printchard force-pushed the network-tier-config branch from f3e2e4d to d5c98ad Compare September 17, 2025 21:40

printchard force-pushed the network-tier-config branch from d5c98ad to 4b282a9 Compare October 9, 2025 20:54

This comment was marked as outdated.

Sign in to view

printchard marked this pull request as ready for review October 20, 2025 17:16

github-actions bot requested a review from melinath October 20, 2025 17:17

printchard added 8 commits October 21, 2025 20:56

initial changes

89e90e7

Fix some typos

7703031

Add suppress func for unspecified network tier

5e3f23c

Update documentation

d0c9161

Add test

8da58c5

Fix test and update dependency

6273a8e

Change suppress function for computed field

82c1202

fix documentation

3acca55

printchard force-pushed the network-tier-config branch from 1810cbc to 3acca55 Compare October 21, 2025 21:02

This comment was marked as outdated.

Sign in to view

remove min master version from test

58c74a1

This comment was marked as outdated.

Sign in to view

melinath requested changes Oct 27, 2025

View reviewed changes

change update test logic and make nested fields required.

9fc8764

github-actions bot requested a review from melinath October 28, 2025 22:45

printchard commented Oct 28, 2025

View reviewed changes

melinath approved these changes Oct 29, 2025

View reviewed changes

melinath added this pull request to the merge queue Oct 29, 2025

Merged via the queue into GoogleCloudPlatform:main with commit ad90670 Oct 29, 2025
23 of 24 checks passed

This was referenced Oct 29, 2025

Add support for Network Tier configuration hashicorp/terraform-provider-google-beta#10960

Merged

Add support for Network Tier configuration hashicorp/terraform-provider-google#24877

Merged

akerekes pushed a commit to akerekes/magic-modules that referenced this pull request Oct 29, 2025

Add support for Network Tier configuration (GoogleCloudPlatform#15083)

702cc45

SirGitsalot pushed a commit that referenced this pull request Oct 30, 2025

Add support for Network Tier configuration (#15083)

2705249

bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Nov 24, 2025

Add support for Network Tier configuration (GoogleCloudPlatform#15083)

b2a7d68

JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026

Add support for Network Tier configuration (GoogleCloudPlatform#15083)

49ab074

	Optional: true,
	Default: "NETWORK_TIER_DEFAULT",
	Required: true,

Conversation

printchard commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Sep 8, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented Sep 8, 2025

Non-exercised tests

Tests analytics

Uh oh!

modular-magician commented Sep 17, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented Sep 17, 2025

Non-exercised tests

Tests analytics

Uh oh!

modular-magician commented Oct 9, 2025

Diff report

Missing doc report (experimental)

Uh oh!

This comment was marked as outdated.

modular-magician commented Oct 9, 2025

Diff report

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Oct 20, 2025

Uh oh!

printchard commented Oct 20, 2025

Test failures analysis

Recording mode

Replaying mode

Uh oh!

modular-magician commented Oct 21, 2025

Diff report

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

printchard commented Oct 22, 2025

Test failures analysis

Uh oh!

printchard commented Oct 23, 2025

Uh oh!

modular-magician commented Oct 23, 2025

Diff report

Uh oh!

modular-magician commented Oct 23, 2025

Tests analytics

Action taken

Uh oh!

This comment was marked as outdated.

printchard commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

shuyama1 commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Oct 27, 2025

Diff report

Uh oh!

modular-magician commented Oct 27, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Oct 27, 2025

Uh oh!

printchard commented Oct 27, 2025

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

melinath Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

printchard commented Sep 8, 2025 •

edited

Loading

shuyama1 commented Oct 27, 2025 •

edited

Loading